scripts-remove doesn't delete Rails databases

[adehnert]

If you autoinstall a Rails app and then remove it, you'll still be left with the *_development, *_test, and *_production databases.

[elefthei]

Patch: ​http://web.mit.edu/elefthei/scripts-remove.patch

[achernya]

As per conversation on zephyr, the current patch was NAK'd by Adam, as it hardcodes the rails databases. Instead, the database names should be pulled out from config/database.yml.

Also, it has bashisms in it, but we don't care as this is a bash script.

[geofft]

Also a nitpick:

railsuffixes=( "test" "development" "production" )

for dbsuffix in ${railsuffixes[@]}; do

As a matter of quoting hygiene (though it doesn't really matter here), you should quote "${railsuffixes[@]}", and you don't need to quote the elements of the array. (Although for this, it's simpler to just say for dbsuffix in test development production, but you might end up changing that per Adam's suggestion.)

[elefthei]

Note to future self; Pull db names from config/databases.yml instead of hardcoding them, to deal with potential updates in rails' policy.

[elefthei]

fixed version of scripts-remove that deletes rails dbs as documented on config/databases.yml

[elefthei]

Ping? :P

[andersk]

Ohai! Sorry we forgot about this. Now that we’ve moved to GitHub, are you interested in submitting this as a pull request to ​https://github.com/mit-scripts/scripts-locker?