Changeset 462 for locker

Timestamp:

Oct 13, 2007, 10:18:07 PM (17 years ago)

Author:

andersk

Message:

Things that give me nightmares, volume 462.

File:

• locker/deploy/bin/onserver.pm (modified) (4 diffs)

locker/deploy/bin/onserver.pm

@@ -60 +60 @@
     print "\nCreating SQL database for $sname...\n";
    
-    my $getpwd=`/mit/scripts/sql/bin$scriptsdev/get-password`;
+    my $getpwd=system("/mit/scripts/sql/bin$scriptsdev/get-password");
     ($sqlhost, $sqluser, $sqlpass) = split(/\s/, $getpwd);
     
-    $sqldb=`/mit/scripts/sql/bin$scriptsdev/get-next-database "$addrlast"`;
-    $sqldb=`/mit/scripts/sql/bin$scriptsdev/create-database "$sqldb"`;
+    $sqldb=system("/mit/scripts/sql/bin$scriptsdev/get-next-database", $addrlast);
+    $sqldb=system("/mit/scripts/sql/bin$scriptsdev/create-database", $sqldb);
     if($sqldb eq "") {
       print "\nERROR:\n";
@@ -72 +72 @@
       print "If you cannot determine the cause of the problem, please\n";
       print "feel free to contact sql\@mit.edu for assistance.\n";
-      `touch .failed`;
+      open FAILED, ">.failed";
+      close FAILED;
       exit 1;
     }
@@ -80 +81 @@
  
   if(-e "$HOME/web_scripts/$addrend/.admin") { 
-    $admin_password=`cat $HOME/web_scripts/$addrend/.admin`;
+    open ADMIN, "<$HOME/web_scripts/$addrend/.admin";
+    $admin_password=<ADMIN>;
     chomp($admin_password);
+    close ADMIN;
     unlink "$HOME/web_scripts/$addrend/.admin";
   } 
@@ -95 +98 @@
   print VERSION dirname($tarball), "\n";
   close(VERSION);
-  if (0) {
-      `date > .scripts-version`;
-      `stat /mit/scripts/deploy$scriptsdev/$deploy.tar.gz >> .scripts-version`;
-  }
 
   select STDOUT;