Changeset 1342 for trunk/server/fedora/config/etc

Timestamp:

Oct 24, 2009, 12:45:00 PM (15 years ago)

Author:

mitchb

Message:

Improvements to check_ldap_mmr plugin
  o Don't put a newline after each replica's output; the Nagios status
    page only captures the first line, so run them all together on one
    line.
  o Don't return immediately upon finding an error; continue to check
    the other replicas and print status info about them.
  o If any replicas have issues, upgrade the return from "ERROR" (which
    is "UNKNOWN" and doesn't cause an alert) to "WARNING" (a replication
    failure is usually not a problem on the server running the plugin, so
    it's probably not a CRITICAL issue for that machine).

File:

• trunk/server/fedora/config/etc/nagios/check_ldap_mmr.real (modified) (2 diffs)

trunk/server/fedora/config/etc/nagios/check_ldap_mmr.real

@@ -22 +22 @@
 my $result=LDAPSearch($ldap,"objectClass=nsDS5ReplicationAgreement","",$base);
 my @entries = $result->entries;
+my $errors = 0;
+my $errorstring = "Replication error(s): ";
 foreach my $entr ( @entries ) {
     my $servername=$entr->get_value($server);
@@ -32 +34 @@
     $serverlastend =~ s/(....)(..)(..)(..)(..)(..)./$1-$2-$3\ $4:$5:$6/;
     print "Replication to $servername last operation $serverlaststart ";
-    print "Status: $serverstatus.\n";
+    print "Status: $serverstatus.     ";
     if ($statuscode) {
-        &nagios_return("ERROR", "Replication error: " . $serverstatus);
+        $errors++;
+        $errorstring = $errorstring . $serverstatus . ", ";
     }
 }
-&nagios_return("OK", "All replicas are OK");
+if ($errors > 0) {
+    &nagios_return("WARNING", $errorstring);
+} else {
+    &nagios_return("OK", "All replicas are OK");
+}
 
 sub ConnectLdap {