Do something sensible on 'athrun scripts scripts -start'

[ezyang]

Note the space before the dash. We don't error until we hit Wizard, which is too late.

[adehnert]

"athrun scripts -start" does error (-start doesn't exist in the scripts locker). I think what was meant here is "athrun scripts scripts -start".

[elefthei]

Patch to trunk/server/common/oursrc/athrun/athrun.sh

[andersk]

elefthei: Please stop closing our tickets without talking to us. Bugs are not fixed until the patch is reviewed, approved, merged into Subversion, and deployed.

$ athrun scripts scripts -start
…
If you have trouble logging in, see http://scripts.mit.edu/faq/41/.
Usage: wizard install APP DIR [ -- SETUPARGS ]

Autoinstalls the application APP in the directory DIR.
This command will interactively ask for information to
complete the autoinstall.

You can also use --help with APP and DIR to find out what
are required SETUPARGS if you want to run this non-interactively
(the distribution of required and optional arguments may change
depending on what directory you are installing to.)

wizard: error: no such option: -s
Connection to scripts.mit.edu closed.

[geofft]

Patch to trunk/server/common/oursrc/athrun/athrun.sh

Is this for a different ticket? This ticket is about running "scripts -start" on Athena, which is I think unrelated to the fake athrun implementation on scripts.

[elefthei]

patch on trunk/locker/bin/scripts that takes care of arguments like ./scripts -start or ./scripts --start

[adehnert]

As per comment:6, "Bugs are not fixed until the patch is reviewed, approved, merged into Subversion, and deployed."

[geofft]

First off, I don't think this feature is particularly helpful, since there's no need to call scripts-start mediawiki when you could just run scripts-mediawiki.

Past that, I'm a little skeptical of this code in particular because of its complexity:

for choice in `choices`; do 
  possibleChoice=`echo "$choice"|awk -F'[- ]' '{ print "-"$2 }'` 
  if [ "$possibleChoice" = "$1" -o "-$possibleChoice" = "$1" ]; then 
    num=`choices|grep -n '\'"$possibleChoice"|awk -F: '{ print $1 }'` 
    found=1 
    break 
  fi 
done 

If we decide we want this feature, is it possible to do it with something simpler on the order of

num=0
choices | while read choice description; do
   num=$((num+1))
   ...
done

?

[geofft]

We no longer refer to scripts-start on our website (just scripts), so I'm going to WONTFIX this, since that completely avoids the problem of people thinking of it as scripts -start.