From: joey Date: Mon, 30 Apr 2007 21:32:24 +0000 (+0000) Subject: * Fix a bug that prevented clearing email or subscriptions. X-Git-Url: https://scripts.mit.edu/gitweb/www/ikiwiki.git/commitdiff_plain/9026ae05c2e7b26c0021e9ecf6dcff64a1dc0ca9 * Fix a bug that prevented clearing email or subscriptions. --- diff --git a/IkiWiki/Plugin/passwordauth.pm b/IkiWiki/Plugin/passwordauth.pm index 86a5ba49e..a2e774c36 100644 --- a/IkiWiki/Plugin/passwordauth.pm +++ b/IkiWiki/Plugin/passwordauth.pm @@ -189,7 +189,7 @@ sub formbuilder (@) { #{{{ if ($form->submitted eq "Save Preferences" && $form->validate) { my $user_name=$form->field('name'); foreach my $field (qw(password)) { - if (defined $form->field($field) && length $form->field($field)) { + if (defined $form->field($field)) { IkiWiki::userinfo_set($user_name, $field, $form->field($field)) || error("failed to set $field"); } diff --git a/debian/changelog b/debian/changelog index 7cfc2b12d..09ccb42aa 100644 --- a/debian/changelog +++ b/debian/changelog @@ -4,8 +4,9 @@ ikiwiki (2.1) UNRELEASED; urgency=low styled using the stylesheet, rather than by creating signin and prefs templates. * Make the openid login form nicely styled. + * Fix a bug that prevented clearing email or subscriptions. - -- Joey Hess Mon, 30 Apr 2007 17:53:10 -0400 + -- Joey Hess Mon, 30 Apr 2007 18:04:02 -0400 ikiwiki (2.00) unstable; urgency=low diff --git a/doc/bugs/clearing_email_in_prefs.mdwn b/doc/bugs/clearing_email_in_prefs.mdwn index 8ed7bc4ce..f03d9d902 100644 --- a/doc/bugs/clearing_email_in_prefs.mdwn +++ b/doc/bugs/clearing_email_in_prefs.mdwn @@ -1,3 +1,5 @@ If a user has an email address in their prefs, and they try to clear it, the prefs seem to save ok, and the email seems to be gone, but reloading the prefs page will reveal the old email address. + +Also affected subscriptions.. [[done]]