X-Git-Url: https://scripts.mit.edu/gitweb/www/ikiwiki.git/blobdiff_plain/055179cb4cc9b8bc9b204e1a9f83b1f59e13824e..489a6fc8bf363aa47cd0a28ab7cfce4254e69bb6:/IkiWiki/Plugin/external.pm?ds=sidebyside
diff --git a/IkiWiki/Plugin/external.pm b/IkiWiki/Plugin/external.pm
index 8d1baa587..204442c1e 100644
--- a/IkiWiki/Plugin/external.pm
+++ b/IkiWiki/Plugin/external.pm
@@ -29,6 +29,7 @@ sub import { #{{{
$plugins{$plugin}={in => $plugin_read, out => $plugin_write, pid => $pid,
accum => ""};
+ $RPC::XML::ENCODING="utf-8";
rpc_call($plugins{$plugin}, "import");
} #}}}
@@ -58,14 +59,31 @@ sub rpc_call ($$;@) { #{{{
error("XML RPC parser failure: $r") unless ref $r;
if ($r->isa('RPC::XML::response')) {
my $value=$r->value;
- if ($value->isa('RPC::XML::array')) {
+ if ($r->is_fault($value)) {
+ # throw the error as best we can
+ print STDERR $value->string."\n";
+ return "";
+ }
+ elsif ($value->isa('RPC::XML::array')) {
return @{$value->value};
}
elsif ($value->isa('RPC::XML::struct')) {
- return %{$value->value};
- }
- elsif ($value->isa('RPC::XML::fault')) {
- die $value->string;
+ my %hash=%{$value->value};
+
+ # XML-RPC v1 does not allow for
+ # nil/null/None/undef values to be
+ # transmitted, so until
+ # XML::RPC::Parser honours v2
+ # (), external plugins send
+ # a hash with one key "null" pointing
+ # to an empty string.
+ if (exists $hash{null} &&
+ $hash{null} eq "" &&
+ int(keys(%hash)) == 1) {
+ return undef;
+ }
+
+ return %hash;
}
else {
return $value->value;
@@ -89,6 +107,14 @@ sub rpc_call ($$;@) { #{{{
error("XML RPC call error, unknown function: $name");
}
+ # XML-RPC v1 does not allow for nil/null/None/undef
+ # values to be transmitted, so until XML::RPC::Parser
+ # honours v2 (), send a hash with one key "null"
+ # pointing to an empty string.
+ if (! defined $ret) {
+ $ret={"null" => ""};
+ }
+
my $string=eval { RPC::XML::response->new($ret)->as_string };
if ($@ && ref $ret) {
# One common reason for serialisation to
@@ -125,9 +151,10 @@ sub setvar ($$$;@) { #{{{
my $plugin=shift;
my $varname="IkiWiki::".shift;
my $key=shift;
+ my $value=shift;
no strict 'refs';
- my $ret=$varname->{$key}=@_;
+ my $ret=$varname->{$key}=$value;
use strict 'refs';
return $ret;
} #}}}
@@ -146,8 +173,22 @@ sub setstate ($$$$;@) { #{{{
my $page=shift;
my $id=shift;
my $key=shift;
+ my $value=shift;
+
+ return $IkiWiki::pagestate{$page}{$id}{$key}=$value;
+} #}}}
+
+sub getargv ($) { #{{{
+ my $plugin=shift;
+
+ return \@ARGV;
+} #}}}
+
+sub setargv ($@) { #{{{
+ my $plugin=shift;
+ my $array=shift;
- return $IkiWiki::pagestate{$page}{$id}{$key}=@_;
+ @ARGV=@$array;
} #}}}
sub inject ($@) { #{{{
@@ -176,7 +217,8 @@ sub hook ($@) { #{{{
delete $params{call};
IkiWiki::hook(%params, call => sub {
- IkiWiki::Plugin::external::rpc_call($plugin, $callback, @_)
+ my $ret=IkiWiki::Plugin::external::rpc_call($plugin, $callback, @_);
+ return $ret;
});
} #}}}