Don't clone with shared, to speed up object access.

Signed-off-by: Edward Z. Yang <ezyang@mit.edu>

diff --git a/TODO b/TODO
index 5e31b21eb2d98becf1e32b0c00c4a365aa66a25f..52a7a8a9b38e6bfa95821de24ab7e48a94e7477c 100644 (file)
--- a/TODO
+++ b/TODO
@@ -1,5 +1,13 @@
 - Bug out immediately if tags are not present in the master tip
   of the repository
+- pending doesn't seem to get written out properly sometimes (or
+  it's being deleted); this makes it hard to --continue on the
+  event of an upgrade failure.  Also, we seem to bounce back to
+  the production copy to check pending even when we run --continue
+  from the working dir.
+- Newline checks are /really really/ expensive on AFS; see if
+  we can minimize them or something.  Right now, we're testing
+  a fix where we don't clone with --shared.
 
 - [SCRIPTS] MediaWiki 1.6.7, 1.9.3 and 1.10.0
 

diff --git a/wizard/command/upgrade.py b/wizard/command/upgrade.py
index 87e6199ae6e2ecbcd73cfa1bacf2928f57eba6d7..f963cf487301eb55d6866086e24f84670e17a417 100644 (file)
--- a/wizard/command/upgrade.py
+++ b/wizard/command/upgrade.py
@@ -290,7 +290,7 @@ class Upgrade(object):
         self.temp_dir = tempfile.mkdtemp(prefix="wizard", dir=dir)
         self.temp_wc_dir = os.path.join(self.temp_dir, "repo")
         logging.info("Using temporary directory: " + self.temp_wc_dir)
-        shell.call("git", "clone", "-q", "--shared", ".", self.temp_wc_dir)
+        shell.call("git", "clone", "-q", ".", self.temp_wc_dir)
     def mergeSaveState(self):
         """Save variables so that ``--continue`` will work."""
         # yeah yeah no trailing newline whatever