]> scripts.mit.edu Git - wizard.git/blobdiff - wizard/command/upgrade.py
Suppress ^M characters from Git progress bars.
[wizard.git] / wizard / command / upgrade.py
index 9f388e047eb4d8820a7ff82cd75f23cc4f096db3..4efbda83ae3f18f87dd366e0a471cfcfab4d90f6 100644 (file)
@@ -8,7 +8,7 @@ import errno
 import tempfile
 import itertools
 
-from wizard import command, deploy, shell, util
+from wizard import app, command, deploy, shell, util
 
 def main(argv, baton):
     options, args = parse_args(argv, baton)
@@ -18,6 +18,8 @@ def main(argv, baton):
         dir = "."
     shell.drop_priviledges(dir, options.log_file)
     util.chdir(dir)
+    if os.path.exists(".scripts/blacklisted"):
+        raise BlacklistedError()
     sh = shell.Shell()
     util.set_git_env()
     if options.continue_:
@@ -39,6 +41,8 @@ def main(argv, baton):
         d.verifyGit(options.srv_path)
         d.verifyConfigured()
         d.verifyVersion()
+        if not options.dry_run:
+            d.verifyWeb()
         repo = d.application.repository(options.srv_path)
         version = calculate_newest_version(sh, repo)
         if version == d.app_version.scripts_tag and not options.force:
@@ -48,7 +52,7 @@ def main(argv, baton):
         temp_wc_dir = perform_tmp_clone(sh)
         with util.ChangeDirectory(temp_wc_dir):
             sh.call("git", "remote", "add", "scripts", repo)
-            sh.call("git", "fetch", "scripts")
+            sh.call("git", "fetch", "-q", "scripts")
             user_commit, next_commit = calculate_parents(sh, version)
             # save variables so that --continue will work
             # yeah yeah no trailing newline whatever
@@ -58,6 +62,11 @@ def main(argv, baton):
             perform_merge(sh, repo, d, version)
     # variables: version, user_commit, next_commit, temp_wc_dir
     with util.ChangeDirectory(temp_wc_dir):
+        try:
+            sh.call("git", "status")
+            sh.call("git", "commit", "-m", "throw-away commit")
+        except shell.CallError:
+            pass
         message = make_commit_message(version)
         new_tree = sh.eval("git", "rev-parse", "HEAD^{tree}")
         final_commit = sh.eval("git", "commit-tree", new_tree,
@@ -65,26 +74,49 @@ def main(argv, baton):
         # a master branch may not necessarily exist if the user
         # was manually installed to an earlier version
         try:
-            sh.call("git", "checkout", "-b", "master", "--")
+            sh.call("git", "checkout", "-q", "-b", "master", "--")
         except shell.CallError:
-            sh.call("git", "checkout", "master", "--")
-        sh.call("git", "reset", "--hard", final_commit)
+            sh.call("git", "checkout", "-q", "master", "--")
+        sh.call("git", "reset", "-q", "--hard", final_commit)
+        d.verifyVersion()
     # Till now, all of our operations were in a tmp sandbox.
     if options.dry_run:
         logging.info("Dry run, bailing.  See results at %s" % temp_wc_dir)
         return
+    # perform database backup
+    backup = d.backup(options)
     # XXX: frob .htaccess to make site inaccessible
-    # XXX: need locking
-    # git merge (which performs a fast forward)
-    #   - merge could fail (race); that's /really/ dangerous.
-    sh.call("git", "pull", temp_wc_dir, "master")
-    # run update script
-    version_obj = distutils.version.LooseVersion(version.partition('-')[2])
-    d.application.upgrade(version_obj, options)
+    with util.IgnoreKeyboardInterrupts():
+        with util.LockDirectory(".scripts-upgrade-lock"):
+            # git merge (which performs a fast forward)
+            sh.call("git", "pull", "-q", temp_wc_dir, "master")
+            version_obj = distutils.version.LooseVersion(version.partition('-')[2])
+            try:
+                # run update script
+                d.upgrade(version_obj, options)
+                d.verifyWeb()
+            except app.UpgradeFailure:
+                logging.warning("Upgrade failed: rolling back")
+                perform_restore(d, backup)
+                raise
+            except deploy.WebVerificationError as e:
+                logging.warning("Web verification failed: rolling back")
+                logging.info("Web page that was output was:\n\n%s" % e.contents)
+                perform_restore(d, backup)
+                raise app.UpgradeVerificationFailure("Upgrade caused website to become inaccessible; site was rolled back")
     # XXX: frob .htaccess to make site accessible
-    # XXX:  - check if .htaccess changed, first.  Upgrade
+    #       to do this, check if .htaccess changed, first.  Upgrade
     #       process might have frobbed it.  Don't be
-    #       particularly worried if the segment dissappeared
+    #       particularly worried if the segment disappeared
+
+def perform_restore(d, backup):
+    # You don't want d.restore() because it doesn't perform
+    # the file level backup
+    shell.Shell().call("wizard", "restore", backup)
+    try:
+        d.verifyWeb()
+    except deploy.WebVerificationError:
+        logging.critical("Web verification failed after rollback")
 
 def make_commit_message(version):
     message = "Upgraded autoinstall in %s to %s.\n\n%s" % (util.get_dir_owner(), version, util.get_git_footer())
@@ -118,7 +150,7 @@ def perform_tmp_clone(sh):
     temp_dir = tempfile.mkdtemp(prefix="wizard")
     temp_wc_dir = os.path.join(temp_dir, "repo")
     logging.info("Using temporary directory: " + temp_wc_dir)
-    sh.call("git", "clone", "--shared", ".", temp_wc_dir)
+    sh.call("git", "clone", "-q", "--shared", ".", temp_wc_dir)
     return temp_wc_dir
 
 def perform_merge(sh, repo, d, version):
@@ -127,7 +159,7 @@ def perform_merge(sh, repo, d, version):
     # crazy merge algorithm:
     def make_virtual_commit(tag, parents = []):
         """WARNING: Changes state of Git repository"""
-        sh.call("git", "checkout", tag, "--")
+        sh.call("git", "checkout", "-q", tag, "--")
         d.parametrize(".")
         for file in d.application.parametrized_files:
             try:
@@ -191,9 +223,8 @@ class MergeFailed(Error):
 
 ERROR: Merge failed.  Resolve the merge by cd'ing to the
 temporary directory, finding conflicted files with `git status`,
-resolving the files, adding them using `git add`, and then
-committing your changes with `git commit` (your log message
-will be ignored), and then running `wizard upgrade --continue`."""
+resolving the files, adding them using `git add` and then
+running `wizard upgrade --continue`."""
 
 class LocalChangesError(Error):
     def __str__(self):
@@ -205,3 +236,10 @@ The best way to resolve this is probably to attempt an upgrade again,
 with git rerere to remember merge resolutions (XXX: not sure if
 this actually works)."""
 
+class BlacklistedError(Error):
+    def __str__(self):
+        return """
+
+ERROR: This autoinstall was manually blacklisted against errors;
+if the user has not been notified of this, please send them
+mail."""