X-Git-Url: https://scripts.mit.edu/gitweb/autoinstallsdev/mediawiki.git/blobdiff_plain/19e297c21b10b1b8a3acad5e73fc71dcb35db44a..6932310fd58ebef145fa01eb76edf7150284d8ea:/includes/specials/SpecialRecentchanges.php diff --git a/includes/specials/SpecialRecentchanges.php b/includes/specials/SpecialRecentchanges.php index c012beca..40834cb5 100644 --- a/includes/specials/SpecialRecentchanges.php +++ b/includes/specials/SpecialRecentchanges.php @@ -21,721 +21,992 @@ * @ingroup SpecialPage */ +use MediaWiki\MediaWikiServices; +use Wikimedia\Rdbms\ResultWrapper; +use Wikimedia\Rdbms\FakeResultWrapper; + /** * A special page that lists last changes made to the wiki * * @ingroup SpecialPage */ -class SpecialRecentChanges extends IncludableSpecialPage { - var $rcOptions, $rcSubpage; +class SpecialRecentChanges extends ChangesListSpecialPage { + + protected static $savedQueriesPreferenceName = 'rcfilters-saved-queries'; + + private $watchlistFilterGroupDefinition; + + // @codingStandardsIgnoreStart Needed "useless" override to change parameters. + public function __construct( $name = 'Recentchanges', $restriction = '' ) { + parent::__construct( $name, $restriction ); + + $this->watchlistFilterGroupDefinition = [ + 'name' => 'watchlist', + 'title' => 'rcfilters-filtergroup-watchlist', + 'class' => ChangesListStringOptionsFilterGroup::class, + 'priority' => -9, + 'isFullCoverage' => true, + 'filters' => [ + [ + 'name' => 'watched', + 'label' => 'rcfilters-filter-watchlist-watched-label', + 'description' => 'rcfilters-filter-watchlist-watched-description', + 'cssClassSuffix' => 'watched', + 'isRowApplicableCallable' => function ( $ctx, $rc ) { + return $rc->getAttribute( 'wl_user' ); + } + ], + [ + 'name' => 'watchednew', + 'label' => 'rcfilters-filter-watchlist-watchednew-label', + 'description' => 'rcfilters-filter-watchlist-watchednew-description', + 'cssClassSuffix' => 'watchednew', + 'isRowApplicableCallable' => function ( $ctx, $rc ) { + return $rc->getAttribute( 'wl_user' ) && + $rc->getAttribute( 'rc_timestamp' ) && + $rc->getAttribute( 'wl_notificationtimestamp' ) && + $rc->getAttribute( 'rc_timestamp' ) >= $rc->getAttribute( 'wl_notificationtimestamp' ); + }, + ], + [ + 'name' => 'notwatched', + 'label' => 'rcfilters-filter-watchlist-notwatched-label', + 'description' => 'rcfilters-filter-watchlist-notwatched-description', + 'cssClassSuffix' => 'notwatched', + 'isRowApplicableCallable' => function ( $ctx, $rc ) { + return $rc->getAttribute( 'wl_user' ) === null; + }, + ] + ], + 'default' => ChangesListStringOptionsFilterGroup::NONE, + 'queryCallable' => function ( $specialPageClassName, $context, $dbr, + &$tables, &$fields, &$conds, &$query_options, &$join_conds, $selectedValues ) { + sort( $selectedValues ); + $notwatchedCond = 'wl_user IS NULL'; + $watchedCond = 'wl_user IS NOT NULL'; + $newCond = 'rc_timestamp >= wl_notificationtimestamp'; + + if ( $selectedValues === [ 'notwatched' ] ) { + $conds[] = $notwatchedCond; + return; + } - public function __construct( $name = 'Recentchanges' ) { - parent::__construct( $name ); - } + if ( $selectedValues === [ 'watched' ] ) { + $conds[] = $watchedCond; + return; + } - /** - * Get a FormOptions object containing the default options - * - * @return FormOptions - */ - public function getDefaultOptions() { - global $wgUser; - $opts = new FormOptions(); + if ( $selectedValues === [ 'watchednew' ] ) { + $conds[] = $dbr->makeList( [ + $watchedCond, + $newCond + ], LIST_AND ); + return; + } - $opts->add( 'days', (int)$wgUser->getOption( 'rcdays' ) ); - $opts->add( 'limit', (int)$wgUser->getOption( 'rclimit' ) ); - $opts->add( 'from', '' ); + if ( $selectedValues === [ 'notwatched', 'watched' ] ) { + // no filters + return; + } - $opts->add( 'hideminor', $wgUser->getBoolOption( 'hideminor' ) ); - $opts->add( 'hidebots', true ); - $opts->add( 'hideanons', false ); - $opts->add( 'hideliu', false ); - $opts->add( 'hidepatrolled', $wgUser->getBoolOption( 'hidepatrolled' ) ); - $opts->add( 'hidemyself', false ); + if ( $selectedValues === [ 'notwatched', 'watchednew' ] ) { + $conds[] = $dbr->makeList( [ + $notwatchedCond, + $dbr->makeList( [ + $watchedCond, + $newCond + ], LIST_AND ) + ], LIST_OR ); + return; + } - $opts->add( 'namespace', '', FormOptions::INTNULL ); - $opts->add( 'invert', false ); + if ( $selectedValues === [ 'watched', 'watchednew' ] ) { + $conds[] = $watchedCond; + return; + } - $opts->add( 'categories', '' ); - $opts->add( 'categories_any', false ); - $opts->add( 'tagfilter', '' ); - return $opts; + if ( $selectedValues === [ 'notwatched', 'watched', 'watchednew' ] ) { + // no filters + return; + } + } + ]; } + // @codingStandardsIgnoreEnd /** - * Create a FormOptions object with options as specified by the user + * Main execution point * - * @return FormOptions + * @param string $subpage */ - public function setup( $parameters ) { - global $wgRequest; + public function execute( $subpage ) { + // Backwards-compatibility: redirect to new feed URLs + $feedFormat = $this->getRequest()->getVal( 'feed' ); + if ( !$this->including() && $feedFormat ) { + $query = $this->getFeedQuery(); + $query['feedformat'] = $feedFormat === 'atom' ? 'atom' : 'rss'; + $this->getOutput()->redirect( wfAppendQuery( wfScript( 'api' ), $query ) ); - $opts = $this->getDefaultOptions(); - $opts->fetchValuesFromRequest( $wgRequest ); + return; + } - // Give precedence to subpage syntax - if( $parameters !== null ) { - $this->parseParameters( $parameters, $opts ); + // 10 seconds server-side caching max + $out = $this->getOutput(); + $out->setCdnMaxage( 10 ); + // Check if the client has a cached version + $lastmod = $this->checkLastModified(); + if ( $lastmod === false ) { + return; } - $opts->validateIntBounds( 'limit', 0, 5000 ); - return $opts; - } + $this->addHelpLink( + '//meta.wikimedia.org/wiki/Special:MyLanguage/Help:Recent_changes', + true + ); + parent::execute( $subpage ); - /** - * Create a FormOptions object specific for feed requests and return it - * - * @return FormOptions - */ - public function feedSetup() { - global $wgFeedLimit, $wgRequest; - $opts = $this->getDefaultOptions(); - # Feed is cached on limit,hideminor,namespace; other params would randomly not work - $opts->fetchValuesFromRequest( $wgRequest, array( 'limit', 'hideminor', 'namespace' ) ); - $opts->validateIntBounds( 'limit', 0, $wgFeedLimit ); - return $opts; + if ( $this->isStructuredFilterUiEnabled() ) { + $out->addJsConfigVars( 'wgStructuredChangeFiltersLiveUpdateSupported', true ); + } } /** - * Get the current FormOptions for this request + * @inheritDoc */ - public function getOptions() { - if ( $this->rcOptions === null ) { - global $wgRequest; - $feedFormat = $wgRequest->getVal( 'feed' ); - $this->rcOptions = $feedFormat ? $this->feedSetup() : $this->setup( $this->rcSubpage ); + protected function transformFilterDefinition( array $filterDefinition ) { + if ( isset( $filterDefinition['showHideSuffix'] ) ) { + $filterDefinition['showHide'] = 'rc' . $filterDefinition['showHideSuffix']; } - return $this->rcOptions; - } + return $filterDefinition; + } /** - * Main execution point - * - * @param $subpage String + * @inheritDoc */ - public function execute( $subpage ) { - global $wgRequest, $wgOut; - $this->rcSubpage = $subpage; - $feedFormat = $wgRequest->getVal( 'feed' ); - - # 10 seconds server-side caching max - $wgOut->setSquidMaxage( 10 ); - # Check if the client has a cached version - $lastmod = $this->checkLastModified( $feedFormat ); - if( $lastmod === false ) { - return; + protected function registerFilters() { + parent::registerFilters(); + + if ( + !$this->including() && + $this->getUser()->isLoggedIn() && + $this->getUser()->isAllowed( 'viewmywatchlist' ) + ) { + $this->registerFiltersFromDefinitions( [ $this->watchlistFilterGroupDefinition ] ); + $watchlistGroup = $this->getFilterGroup( 'watchlist' ); + $watchlistGroup->getFilter( 'watched' )->setAsSupersetOf( + $watchlistGroup->getFilter( 'watchednew' ) + ); } - $opts = $this->getOptions(); - $this->setHeaders(); - $this->outputHeader(); + $user = $this->getUser(); - // Fetch results, prepare a batch link existence check query - $conds = $this->buildMainQueryConds( $opts ); - $rows = $this->doMainQuery( $conds, $opts ); - if( $rows === false ){ - if( !$this->including() ) { - $this->doHeader( $opts ); - } - return; - } + $significance = $this->getFilterGroup( 'significance' ); + $hideMinor = $significance->getFilter( 'hideminor' ); + $hideMinor->setDefault( $user->getBoolOption( 'hideminor' ) ); - if( !$feedFormat ) { - $batch = new LinkBatch; - foreach( $rows as $row ) { - $batch->add( NS_USER, $row->rc_user_text ); - $batch->add( NS_USER_TALK, $row->rc_user_text ); - $batch->add( $row->rc_namespace, $row->rc_title ); - } - $batch->execute(); - } - if( $feedFormat ) { - list( $changesFeed, $formatter ) = $this->getFeedObject( $feedFormat ); - $changesFeed->execute( $formatter, $rows, $lastmod, $opts ); - } else { - $this->webOutput( $rows, $opts ); + $automated = $this->getFilterGroup( 'automated' ); + $hideBots = $automated->getFilter( 'hidebots' ); + $hideBots->setDefault( true ); + + $reviewStatus = $this->getFilterGroup( 'reviewStatus' ); + if ( $reviewStatus !== null ) { + // Conditional on feature being available and rights + $hidePatrolled = $reviewStatus->getFilter( 'hidepatrolled' ); + $hidePatrolled->setDefault( $user->getBoolOption( 'hidepatrolled' ) ); } - $rows->free(); + $changeType = $this->getFilterGroup( 'changeType' ); + $hideCategorization = $changeType->getFilter( 'hidecategorization' ); + if ( $hideCategorization !== null ) { + // Conditional on feature being available + $hideCategorization->setDefault( $user->getBoolOption( 'hidecategorization' ) ); + } } /** - * Return an array with a ChangesFeed object and ChannelFeed object + * Get a FormOptions object containing the default options * - * @return Array + * @return FormOptions */ - public function getFeedObject( $feedFormat ){ - $changesFeed = new ChangesFeed( $feedFormat, 'rcfeed' ); - $formatter = $changesFeed->getFeedObject( - wfMsgForContent( 'recentchanges' ), - wfMsgForContent( 'recentchanges-feed-description' ) - ); - return array( $changesFeed, $formatter ); + public function getDefaultOptions() { + $opts = parent::getDefaultOptions(); + + $opts->add( 'days', $this->getDefaultDays(), FormOptions::FLOAT ); + $opts->add( 'limit', $this->getDefaultLimit() ); + $opts->add( 'from', '' ); + + $opts->add( 'categories', '' ); + $opts->add( 'categories_any', false ); + + return $opts; } /** - * Process $par and put options found if $opts - * Mainly used when including the page + * Get all custom filters * - * @param $par String - * @param $opts FormOptions + * @return array Map of filter URL param names to properties (msg/default) */ - public function parseParameters( $par, FormOptions $opts ) { - $bits = preg_split( '/\s*,\s*/', trim( $par ) ); - foreach( $bits as $bit ) { - if( 'hidebots' === $bit ) $opts['hidebots'] = true; - if( 'bots' === $bit ) $opts['hidebots'] = false; - if( 'hideminor' === $bit ) $opts['hideminor'] = true; - if( 'minor' === $bit ) $opts['hideminor'] = false; - if( 'hideliu' === $bit ) $opts['hideliu'] = true; - if( 'hidepatrolled' === $bit ) $opts['hidepatrolled'] = true; - if( 'hideanons' === $bit ) $opts['hideanons'] = true; - if( 'hidemyself' === $bit ) $opts['hidemyself'] = true; - - if( is_numeric( $bit ) ) $opts['limit'] = $bit; - - $m = array(); - if( preg_match( '/^limit=(\d+)$/', $bit, $m ) ) $opts['limit'] = $m[1]; - if( preg_match( '/^days=(\d+)$/', $bit, $m ) ) $opts['days'] = $m[1]; + protected function getCustomFilters() { + if ( $this->customFilters === null ) { + $this->customFilters = parent::getCustomFilters(); + Hooks::run( 'SpecialRecentChangesFilters', [ $this, &$this->customFilters ], '1.23' ); } + + return $this->customFilters; } /** - * Get last modified date, for client caching - * Don't use this if we are using the patrol feature, patrol changes don't - * update the timestamp + * Process $par and put options found in $opts. Used when including the page. * - * @param $feedFormat String - * @return String or false + * @param string $par + * @param FormOptions $opts */ - public function checkLastModified( $feedFormat ) { - global $wgUseRCPatrol, $wgOut; - $dbr = wfGetDB( DB_SLAVE ); - $lastmod = $dbr->selectField( 'recentchanges', 'MAX(rc_timestamp)', false, __METHOD__ ); - if( $feedFormat || !$wgUseRCPatrol ) { - if( $lastmod && $wgOut->checkLastModified( $lastmod ) ) { - # Client cache fresh and headers sent, nothing more to do. - return false; + public function parseParameters( $par, FormOptions $opts ) { + parent::parseParameters( $par, $opts ); + + $bits = preg_split( '/\s*,\s*/', trim( $par ) ); + foreach ( $bits as $bit ) { + if ( is_numeric( $bit ) ) { + $opts['limit'] = $bit; + } + + $m = []; + if ( preg_match( '/^limit=(\d+)$/', $bit, $m ) ) { + $opts['limit'] = $m[1]; + } + if ( preg_match( '/^days=(\d+(?:\.\d+)?)$/', $bit, $m ) ) { + $opts['days'] = $m[1]; + } + if ( preg_match( '/^namespace=(.*)$/', $bit, $m ) ) { + $opts['namespace'] = $m[1]; + } + if ( preg_match( '/^tagfilter=(.*)$/', $bit, $m ) ) { + $opts['tagfilter'] = $m[1]; } } - return $lastmod; + } + + public function validateOptions( FormOptions $opts ) { + $opts->validateIntBounds( 'limit', 0, 5000 ); + $opts->validateBounds( 'days', 0, $this->getConfig()->get( 'RCMaxAge' ) / ( 3600 * 24 ) ); + parent::validateOptions( $opts ); } /** - * Return an array of conditions depending of options set in $opts - * - * @param $opts FormOptions - * @return array + * @inheritDoc */ - public function buildMainQueryConds( FormOptions $opts ) { - global $wgUser; - - $dbr = wfGetDB( DB_SLAVE ); - $conds = array(); - - # It makes no sense to hide both anons and logged-in users - # Where this occurs, force anons to be shown - $forcebot = false; - if( $opts['hideanons'] && $opts['hideliu'] ){ - # Check if the user wants to show bots only - if( $opts['hidebots'] ){ - $opts['hideanons'] = false; - } else { - $forcebot = true; - $opts['hidebots'] = false; - } - } + protected function buildQuery( &$tables, &$fields, &$conds, + &$query_options, &$join_conds, FormOptions $opts + ) { + $dbr = $this->getDB(); + parent::buildQuery( $tables, $fields, $conds, + $query_options, $join_conds, $opts ); // Calculate cutoff - $cutoff_unixtime = time() - ( $opts['days'] * 86400 ); - $cutoff_unixtime = $cutoff_unixtime - ($cutoff_unixtime % 86400); + $cutoff_unixtime = time() - $opts['days'] * 3600 * 24; $cutoff = $dbr->timestamp( $cutoff_unixtime ); - $fromValid = preg_match('/^[0-9]{14}$/', $opts['from']); - if( $fromValid && $opts['from'] > wfTimestamp(TS_MW,$cutoff) ) { - $cutoff = $dbr->timestamp($opts['from']); + $fromValid = preg_match( '/^[0-9]{14}$/', $opts['from'] ); + if ( $fromValid && $opts['from'] > wfTimestamp( TS_MW, $cutoff ) ) { + $cutoff = $dbr->timestamp( $opts['from'] ); } else { $opts->reset( 'from' ); } $conds[] = 'rc_timestamp >= ' . $dbr->addQuotes( $cutoff ); + } + /** + * @inheritDoc + */ + protected function doMainQuery( $tables, $fields, $conds, $query_options, + $join_conds, FormOptions $opts + ) { + $dbr = $this->getDB(); + $user = $this->getUser(); - $hidePatrol = $wgUser->useRCPatrol() && $opts['hidepatrolled']; - $hideLoggedInUsers = $opts['hideliu'] && !$forcebot; - $hideAnonymousUsers = $opts['hideanons'] && !$forcebot; - - if( $opts['hideminor'] ) $conds['rc_minor'] = 0; - if( $opts['hidebots'] ) $conds['rc_bot'] = 0; - if( $hidePatrol ) $conds['rc_patrolled'] = 0; - if( $forcebot ) $conds['rc_bot'] = 1; - if( $hideLoggedInUsers ) $conds[] = 'rc_user = 0'; - if( $hideAnonymousUsers ) $conds[] = 'rc_user != 0'; + $tables[] = 'recentchanges'; + $fields = array_merge( RecentChange::selectFields(), $fields ); - if( $opts['hidemyself'] ) { - if( $wgUser->getId() ) { - $conds[] = 'rc_user != ' . $dbr->addQuotes( $wgUser->getId() ); - } else { - $conds[] = 'rc_user_text != ' . $dbr->addQuotes( $wgUser->getName() ); - } + // JOIN on watchlist for users + if ( $user->isLoggedIn() && $user->isAllowed( 'viewmywatchlist' ) ) { + $tables[] = 'watchlist'; + $fields[] = 'wl_user'; + $fields[] = 'wl_notificationtimestamp'; + $join_conds['watchlist'] = [ 'LEFT JOIN', [ + 'wl_user' => $user->getId(), + 'wl_title=rc_title', + 'wl_namespace=rc_namespace' + ] ]; } - # Namespace filtering - if( $opts['namespace'] !== '' ) { - if( !$opts['invert'] ) { - $conds[] = 'rc_namespace = ' . $dbr->addQuotes( $opts['namespace'] ); - } else { - $conds[] = 'rc_namespace != ' . $dbr->addQuotes( $opts['namespace'] ); - } + // JOIN on page, used for 'last revision' filter highlight + $tables[] = 'page'; + $fields[] = 'page_latest'; + $join_conds['page'] = [ 'LEFT JOIN', 'rc_cur_id=page_id' ]; + + $tagFilter = $opts['tagfilter'] ? explode( '|', $opts['tagfilter'] ) : []; + ChangeTags::modifyDisplayQuery( + $tables, + $fields, + $conds, + $join_conds, + $query_options, + $tagFilter + ); + + if ( !$this->runMainQueryHook( $tables, $fields, $conds, $query_options, $join_conds, + $opts ) + ) { + return false; } - return $conds; - } + if ( $this->areFiltersInConflict() ) { + return false; + } - /** - * Process the query - * - * @param $conds Array - * @param $opts FormOptions - * @return database result or false (for Recentchangeslinked only) - */ - public function doMainQuery( $conds, $opts ) { - global $wgUser; + $orderByAndLimit = [ + 'ORDER BY' => 'rc_timestamp DESC', + 'LIMIT' => $opts['limit'] + ]; + if ( in_array( 'DISTINCT', $query_options ) ) { + // ChangeTags::modifyDisplayQuery() adds DISTINCT when filtering on multiple tags. + // In order to prevent DISTINCT from causing query performance problems, + // we have to GROUP BY the primary key. This in turn requires us to add + // the primary key to the end of the ORDER BY, and the old ORDER BY to the + // start of the GROUP BY + $orderByAndLimit['ORDER BY'] = 'rc_timestamp DESC, rc_id DESC'; + $orderByAndLimit['GROUP BY'] = 'rc_timestamp, rc_id'; + } + // array_merge() is used intentionally here so that hooks can, should + // they so desire, override the ORDER BY / LIMIT condition(s); prior to + // MediaWiki 1.26 this used to use the plus operator instead, which meant + // that extensions weren't able to change these conditions + $query_options = array_merge( $orderByAndLimit, $query_options ); + $rows = $dbr->select( + $tables, + $fields, + // rc_new is not an ENUM, but adding a redundant rc_new IN (0,1) gives mysql enough + // knowledge to use an index merge if it wants (it may use some other index though). + $conds + [ 'rc_new' => [ 0, 1 ] ], + __METHOD__, + $query_options, + $join_conds + ); - $tables = array( 'recentchanges' ); - $join_conds = array(); - $query_options = array( 'USE INDEX' => array('recentchanges' => 'rc_timestamp') ); + // Build the final data + if ( $this->getConfig()->get( 'AllowCategorizedRecentChanges' ) ) { + $this->filterByCategories( $rows, $opts ); + } - $uid = $wgUser->getId(); - $dbr = wfGetDB( DB_SLAVE ); - $limit = $opts['limit']; - $namespace = $opts['namespace']; - $select = '*'; - $invert = $opts['invert']; + return $rows; + } - // JOIN on watchlist for users - if( $uid ) { - $tables[] = 'watchlist'; - $join_conds['watchlist'] = array('LEFT JOIN', - "wl_user={$uid} AND wl_title=rc_title AND wl_namespace=rc_namespace"); - } - if ($wgUser->isAllowed("rollback")) { - $tables[] = 'page'; - $join_conds['page'] = array('LEFT JOIN', 'rc_cur_id=page_id'); - } - if ( !$this->including() ) { - // Tag stuff. - // Doesn't work when transcluding. See bug 23293 - $fields = array(); - // Fields are * in this case, so let the function modify an empty array to keep it happy. - ChangeTags::modifyDisplayQuery( - $tables, $fields, $conds, $join_conds, $query_options, $opts['tagfilter'] + protected function runMainQueryHook( &$tables, &$fields, &$conds, + &$query_options, &$join_conds, $opts + ) { + return parent::runMainQueryHook( $tables, $fields, $conds, $query_options, $join_conds, $opts ) + && Hooks::run( + 'SpecialRecentChangesQuery', + [ &$conds, &$tables, &$join_conds, $opts, &$query_options, &$fields ], + '1.23' ); - } + } - if ( !wfRunHooks( 'SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts, &$query_options, &$select ) ) ) - return false; + protected function getDB() { + return wfGetDB( DB_REPLICA, 'recentchanges' ); + } - // Don't use the new_namespace_time timestamp index if: - // (a) "All namespaces" selected - // (b) We want all pages NOT in a certain namespaces (inverted) - // (c) There is a tag to filter on (use tag index instead) - // (d) UNION + sort/limit is not an option for the DBMS - if( is_null( $namespace ) - || ( $invert && !is_null( $namespace ) ) - || $opts['tagfilter'] != '' - || !$dbr->unionSupportsOrderAndLimit() ) - { - $res = $dbr->select( $tables, '*', $conds, __METHOD__, - array( 'ORDER BY' => 'rc_timestamp DESC', 'LIMIT' => $limit ) + - $query_options, - $join_conds ); - // We have a new_namespace_time index! UNION over new=(0,1) and sort result set! - } else { - // New pages - $sqlNew = $dbr->selectSQLText( $tables, $select, - array( 'rc_new' => 1 ) + $conds, - __METHOD__, - array( 'ORDER BY' => 'rc_timestamp DESC', 'LIMIT' => $limit, - 'USE INDEX' => array('recentchanges' => 'rc_timestamp') ), - $join_conds ); - // Old pages - $sqlOld = $dbr->selectSQLText( $tables, '*', - array( 'rc_new' => 0 ) + $conds, - __METHOD__, - array( 'ORDER BY' => 'rc_timestamp DESC', 'LIMIT' => $limit, - 'USE INDEX' => array('recentchanges' => 'rc_timestamp') ), - $join_conds ); - # Join the two fast queries, and sort the result set - $sql = $dbr->unionQueries(array($sqlNew, $sqlOld), false).' ORDER BY rc_timestamp DESC'; - $sql = $dbr->limitResult($sql, $limit, false); - $res = $dbr->query( $sql, __METHOD__ ); - } - - return $res; + public function outputFeedLinks() { + $this->addFeedLinks( $this->getFeedQuery() ); } /** - * Send output to $wgOut, only called if not used feeds + * Get URL query parameters for action=feedrecentchanges API feed of current recent changes view. * - * @param $rows Array of database rows - * @param $opts FormOptions + * @return array */ - public function webOutput( $rows, $opts ) { - global $wgOut, $wgUser, $wgRCShowWatchingUsers, $wgShowUpdatedMarker; - global $wgAllowCategorizedRecentChanges; + protected function getFeedQuery() { + $query = array_filter( $this->getOptions()->getAllValues(), function ( $value ) { + // API handles empty parameters in a different way + return $value !== ''; + } ); + $query['action'] = 'feedrecentchanges'; + $feedLimit = $this->getConfig()->get( 'FeedLimit' ); + if ( $query['limit'] > $feedLimit ) { + $query['limit'] = $feedLimit; + } + return $query; + } + + /** + * Build and output the actual changes list. + * + * @param ResultWrapper $rows Database rows + * @param FormOptions $opts + */ + public function outputChangesList( $rows, $opts ) { $limit = $opts['limit']; - if( !$this->including() ) { - // Output options box - $this->doHeader( $opts ); - } + $showWatcherCount = $this->getConfig()->get( 'RCShowWatchingUsers' ) + && $this->getUser()->getOption( 'shownumberswatching' ); + $watcherCache = []; - // And now for the content - $wgOut->setFeedAppendQuery( $this->getFeedQuery() ); + $counter = 1; + $list = ChangesList::newFromContext( $this->getContext(), $this->filterGroups ); + $list->initChangesListRows( $rows ); - if( $wgAllowCategorizedRecentChanges ) { - $this->filterByCategories( $rows, $opts ); + $userShowHiddenCats = $this->getUser()->getBoolOption( 'showhiddencats' ); + $rclistOutput = $list->beginRecentChangesList(); + if ( $this->isStructuredFilterUiEnabled() ) { + $rclistOutput .= $this->makeLegend(); } - $showWatcherCount = $wgRCShowWatchingUsers && $wgUser->getOption( 'shownumberswatching' ); - $watcherCache = array(); - - $dbr = wfGetDB( DB_SLAVE ); + foreach ( $rows as $obj ) { + if ( $limit == 0 ) { + break; + } + $rc = RecentChange::newFromRow( $obj ); - $counter = 1; - $list = ChangesList::newFromUser( $wgUser ); + # Skip CatWatch entries for hidden cats based on user preference + if ( + $rc->getAttribute( 'rc_type' ) == RC_CATEGORIZE && + !$userShowHiddenCats && + $rc->getParam( 'hidden-cat' ) + ) { + continue; + } - $s = $list->beginRecentChangesList(); - foreach( $rows as $obj ) { - if( $limit == 0 ) break; - $rc = RecentChange::newFromRow( $obj ); $rc->counter = $counter++; # Check if the page has been updated since the last visit - if( $wgShowUpdatedMarker && !empty($obj->wl_notificationtimestamp) ) { - $rc->notificationtimestamp = ($obj->rc_timestamp >= $obj->wl_notificationtimestamp); + if ( $this->getConfig()->get( 'ShowUpdatedMarker' ) + && !empty( $obj->wl_notificationtimestamp ) + ) { + $rc->notificationtimestamp = ( $obj->rc_timestamp >= $obj->wl_notificationtimestamp ); } else { $rc->notificationtimestamp = false; // Default } # Check the number of users watching the page $rc->numberofWatchingusers = 0; // Default - if( $showWatcherCount && $obj->rc_namespace >= 0 ) { - if( !isset($watcherCache[$obj->rc_namespace][$obj->rc_title]) ) { + if ( $showWatcherCount && $obj->rc_namespace >= 0 ) { + if ( !isset( $watcherCache[$obj->rc_namespace][$obj->rc_title] ) ) { $watcherCache[$obj->rc_namespace][$obj->rc_title] = - $dbr->selectField( 'watchlist', - 'COUNT(*)', - array( - 'wl_namespace' => $obj->rc_namespace, - 'wl_title' => $obj->rc_title, - ), - __METHOD__ . '-watchers' ); + MediaWikiServices::getInstance()->getWatchedItemStore()->countWatchers( + new TitleValue( (int)$obj->rc_namespace, $obj->rc_title ) + ); } $rc->numberofWatchingusers = $watcherCache[$obj->rc_namespace][$obj->rc_title]; } - $s .= $list->recentChangesLine( $rc, !empty( $obj->wl_user ), $counter ); - --$limit; + + $changeLine = $list->recentChangesLine( $rc, !empty( $obj->wl_user ), $counter ); + if ( $changeLine !== false ) { + $rclistOutput .= $changeLine; + --$limit; + } } - $s .= $list->endRecentChangesList(); - $wgOut->addHTML( $s ); - } + $rclistOutput .= $list->endRecentChangesList(); - /** - * Get the query string to append to feed link URLs. - * This is overridden by RCL to add the target parameter - */ - public function getFeedQuery() { - return false; + if ( $rows->numRows() === 0 ) { + $this->outputNoResults(); + if ( !$this->including() ) { + $this->getOutput()->setStatusCode( 404 ); + } + } else { + $this->getOutput()->addHTML( $rclistOutput ); + } } /** - * Return the text to be displayed above the changes + * Set the text to be displayed above the changes * - * @param $opts FormOptions - * @return String: XHTML + * @param FormOptions $opts + * @param int $numRows Number of rows in the result to show after this header */ - public function doHeader( $opts ) { - global $wgScript, $wgOut; - - $this->setTopText( $wgOut, $opts ); + public function doHeader( $opts, $numRows ) { + $this->setTopText( $opts ); $defaults = $opts->getAllValues(); $nondefaults = $opts->getChangedValues(); - $opts->consumeValues( array( 'namespace', 'invert', 'tagfilter', - 'categories', 'categories_any' ) ); - $panel = array(); - $panel[] = $this->optionsPanel( $defaults, $nondefaults ); + $panel = []; + if ( !$this->isStructuredFilterUiEnabled() ) { + $panel[] = $this->makeLegend(); + } + $panel[] = $this->optionsPanel( $defaults, $nondefaults, $numRows ); $panel[] = '