MediaWiki 1.30.2

[autoinstallsdev/mediawiki.git] / maintenance / updateRestrictions.php

diff --git a/maintenance/updateRestrictions.php b/maintenance/updateRestrictions.php
index c815f4b930e3918c81d245e934fe0f43d71191b5..2f3fc36534e179b6ffe6c5994ef77534d1823c6a 100644 (file)
--- a/maintenance/updateRestrictions.php
+++ b/maintenance/updateRestrictions.php
@@ -24,17 +24,23 @@
  * @ingroup Maintenance
  */
 
-require_once( dirname( __FILE__ ) . '/Maintenance.php' );
+require_once __DIR__ . '/Maintenance.php';
 
+/**
+ * Maintenance script that updates page_restrictions table from
+ * old page_restriction column.
+ *
+ * @ingroup Maintenance
+ */
 class UpdateRestrictions extends Maintenance {
        public function __construct() {
                parent::__construct();
-               $this->mDescription = "Updates page_restrictions table from old page_restriction column";
-               $this->setBatchSize( 100 );
+               $this->addDescription( 'Updates page_restrictions table from old page_restriction column' );
+               $this->setBatchSize( 1000 );
        }
 
        public function execute() {
-               $db = wfGetDB( DB_MASTER );
+               $db = $this->getDB( DB_MASTER );
                if ( !$db->tableExists( 'page_restrictions' ) ) {
                        $this->error( "page_restrictions table does not exist", true );
                }
@@ -51,12 +57,17 @@ class UpdateRestrictions extends Maintenance {
                $blockEnd = $start + $this->mBatchSize - 1;
                $encodedExpiry = 'infinity';
                while ( $blockEnd <= $end ) {
-                       $this->output( "...doing page_id from $blockStart to $blockEnd\n" );
+                       $this->output( "...doing page_id from $blockStart to $blockEnd out of $end\n" );
                        $cond = "page_id BETWEEN $blockStart AND $blockEnd AND page_restrictions !=''";
-                       $res = $db->select( 'page', array( 'page_id', 'page_namespace', 'page_restrictions' ), $cond, __METHOD__ );
-                       $batch = array();
+                       $res = $db->select(
+                               'page',
+                               [ 'page_id', 'page_namespace', 'page_restrictions' ],
+                               $cond,
+                               __METHOD__
+                       );
+                       $batch = [];
                        foreach ( $res as $row ) {
-                               $oldRestrictions = array();
+                               $oldRestrictions = [];
                                foreach ( explode( ':', trim( $row->page_restrictions ) ) as $restrict ) {
                                        $temp = explode( '=', trim( $restrict ) );
                                        // Make sure we are not settings restrictions to ""
@@ -64,48 +75,54 @@ class UpdateRestrictions extends Maintenance {
                                                // old old format should be treated as edit/move restriction
                                                $oldRestrictions["edit"] = trim( $temp[0] );
                                                $oldRestrictions["move"] = trim( $temp[0] );
-                                       } else if ( $temp[1] ) {
+                                       } elseif ( $temp[1] ) {
                                                $oldRestrictions[$temp[0]] = trim( $temp[1] );
                                        }
                                }
                                # Clear invalid columns
                                if ( $row->page_namespace == NS_MEDIAWIKI ) {
-                                       $db->update( 'page', array( 'page_restrictions' => '' ),
-                                               array( 'page_id' => $row->page_id ), __FUNCTION__ );
+                                       $db->update( 'page', [ 'page_restrictions' => '' ],
+                                               [ 'page_id' => $row->page_id ], __FUNCTION__ );
                                        $this->output( "...removed dead page_restrictions column for page {$row->page_id}\n" );
                                }
                                # Update restrictions table
                                foreach ( $oldRestrictions as $action => $restrictions ) {
-                                       $batch[] = array(
+                                       $batch[] = [
                                                'pr_page' => $row->page_id,
                                                'pr_type' => $action,
                                                'pr_level' => $restrictions,
                                                'pr_cascade' => 0,
                                                'pr_expiry' => $encodedExpiry
-                                       );
+                                       ];
                                }
                        }
                        # We use insert() and not replace() as Article.php replaces
                        # page_restrictions with '' when protected in the restrictions table
                        if ( count( $batch ) ) {
-                               $ok = $db->deadlockLoop( array( $db, 'insert' ), 'page_restrictions',
-                                       $batch, __FUNCTION__, array( 'IGNORE' ) );
+                               $ok = $db->deadlockLoop( [ $db, 'insert' ], 'page_restrictions',
+                                       $batch, __FUNCTION__, [ 'IGNORE' ] );
                                if ( !$ok ) {
                                        throw new MWException( "Deadlock loop failed wtf :(" );
                                }
                        }
                        $blockStart += $this->mBatchSize - 1;
                        $blockEnd += $this->mBatchSize - 1;
-                       wfWaitForSlaves( 5 );
+                       wfWaitForSlaves();
                }
                $this->output( "...removing dead rows from page_restrictions\n" );
                // Kill any broken rows from previous imports
-               $db->delete( 'page_restrictions', array( 'pr_level' => '' ) );
+               $db->delete( 'page_restrictions', [ 'pr_level' => '' ] );
                // Kill other invalid rows
-               $db->deleteJoin( 'page_restrictions', 'page', 'pr_page', 'page_id', array( 'page_namespace' => NS_MEDIAWIKI ) );
+               $db->deleteJoin(
+                       'page_restrictions',
+                       'page',
+                       'pr_page',
+                       'page_id',
+                       [ 'page_namespace' => NS_MEDIAWIKI ]
+               );
                $this->output( "...Done!\n" );
        }
 }
 
 $maintClass = "UpdateRestrictions";
-require_once( RUN_MAINTENANCE_IF_MAIN );
+require_once RUN_MAINTENANCE_IF_MAIN;