Wordpress 3.6

[autoinstalls/wordpress.git] / wp-admin / includes / schema.php

diff --git a/wp-admin/includes/schema.php b/wp-admin/includes/schema.php
index f042fdd4066071a368f74c4b970023760efb1681..162651a418cc60fabaeb3017434cf856f359cdf8 100644 (file)
--- a/wp-admin/includes/schema.php
+++ b/wp-admin/includes/schema.php
@@ -494,7 +494,8 @@ function populate_options() {
        // Set autoload to no for these options
        $fat_options = array( 'moderation_keys', 'recently_edited', 'blacklist_keys', 'uninstall_plugins' );
 
-       $existing_options = $wpdb->get_col("SELECT option_name FROM $wpdb->options");
+       $keys = "'" . implode( "', '", array_keys( $options ) ) . "'";
+       $existing_options = $wpdb->get_col( "SELECT option_name FROM $wpdb->options WHERE option_name in ( $keys )" );
 
        $insert = '';
        foreach ( $options as $option => $value ) {
@@ -505,13 +506,11 @@ function populate_options() {
                else
                        $autoload = 'yes';
 
-               $option = $wpdb->escape($option);
                if ( is_array($value) )
                        $value = serialize($value);
-               $value = $wpdb->escape($value);
                if ( !empty($insert) )
                        $insert .= ', ';
-               $insert .= "('$option', '$value', '$autoload')";
+               $insert .= $wpdb->prepare( "(%s, %s, %s)", $option, $value, $autoload );
        }
 
        if ( !empty($insert) )
@@ -588,7 +587,7 @@ function populate_roles_160() {
        add_role('subscriber', 'Subscriber');
 
        // Add caps for Administrator role
-       $role =& get_role('administrator');
+       $role = get_role('administrator');
        $role->add_cap('switch_themes');
        $role->add_cap('edit_themes');
        $role->add_cap('activate_plugins');
@@ -621,7 +620,7 @@ function populate_roles_160() {
        $role->add_cap('level_0');
 
        // Add caps for Editor role
-       $role =& get_role('editor');
+       $role = get_role('editor');
        $role->add_cap('moderate_comments');
        $role->add_cap('manage_categories');
        $role->add_cap('manage_links');
@@ -643,7 +642,7 @@ function populate_roles_160() {
        $role->add_cap('level_0');
 
        // Add caps for Author role
-       $role =& get_role('author');
+       $role = get_role('author');
        $role->add_cap('upload_files');
        $role->add_cap('edit_posts');
        $role->add_cap('edit_published_posts');
@@ -654,14 +653,14 @@ function populate_roles_160() {
        $role->add_cap('level_0');
 
        // Add caps for Contributor role
-       $role =& get_role('contributor');
+       $role = get_role('contributor');
        $role->add_cap('edit_posts');
        $role->add_cap('read');
        $role->add_cap('level_1');
        $role->add_cap('level_0');
 
        // Add caps for Subscriber role
-       $role =& get_role('subscriber');
+       $role = get_role('subscriber');
        $role->add_cap('read');
        $role->add_cap('level_0');
 }
@@ -674,7 +673,7 @@ function populate_roles_160() {
 function populate_roles_210() {
        $roles = array('administrator', 'editor');
        foreach ($roles as $role) {
-               $role =& get_role($role);
+               $role = get_role($role);
                if ( empty($role) )
                        continue;
 
@@ -695,19 +694,19 @@ function populate_roles_210() {
                $role->add_cap('read_private_pages');
        }
 
-       $role =& get_role('administrator');
+       $role = get_role('administrator');
        if ( ! empty($role) ) {
                $role->add_cap('delete_users');
                $role->add_cap('create_users');
        }
 
-       $role =& get_role('author');
+       $role = get_role('author');
        if ( ! empty($role) ) {
                $role->add_cap('delete_posts');
                $role->add_cap('delete_published_posts');
        }
 
-       $role =& get_role('contributor');
+       $role = get_role('contributor');
        if ( ! empty($role) ) {
                $role->add_cap('delete_posts');
        }
@@ -719,7 +718,7 @@ function populate_roles_210() {
  * @since 2.3.0
  */
 function populate_roles_230() {
-       $role =& get_role( 'administrator' );
+       $role = get_role( 'administrator' );
 
        if ( !empty( $role ) ) {
                $role->add_cap( 'unfiltered_upload' );
@@ -732,7 +731,7 @@ function populate_roles_230() {
  * @since 2.5.0
  */
 function populate_roles_250() {
-       $role =& get_role( 'administrator' );
+       $role = get_role( 'administrator' );
 
        if ( !empty( $role ) ) {
                $role->add_cap( 'edit_dashboard' );
@@ -745,7 +744,7 @@ function populate_roles_250() {
  * @since 2.6.0
  */
 function populate_roles_260() {
-       $role =& get_role( 'administrator' );
+       $role = get_role( 'administrator' );
 
        if ( !empty( $role ) ) {
                $role->add_cap( 'update_plugins' );
@@ -759,7 +758,7 @@ function populate_roles_260() {
  * @since 2.7.0
  */
 function populate_roles_270() {
-       $role =& get_role( 'administrator' );
+       $role = get_role( 'administrator' );
 
        if ( !empty( $role ) ) {
                $role->add_cap( 'install_plugins' );
@@ -773,7 +772,7 @@ function populate_roles_270() {
  * @since 2.8.0
  */
 function populate_roles_280() {
-       $role =& get_role( 'administrator' );
+       $role = get_role( 'administrator' );
 
        if ( !empty( $role ) ) {
                $role->add_cap( 'install_themes' );
@@ -786,7 +785,7 @@ function populate_roles_280() {
  * @since 3.0.0
  */
 function populate_roles_300() {
-       $role =& get_role( 'administrator' );
+       $role = get_role( 'administrator' );
 
        if ( !empty( $role ) ) {
                $role->add_cap( 'update_core' );
@@ -921,13 +920,11 @@ We hope you enjoy your new site. Thanks!
 
        $insert = '';
        foreach ( $sitemeta as $meta_key => $meta_value ) {
-               $meta_key = $wpdb->escape( $meta_key );
                if ( is_array( $meta_value ) )
                        $meta_value = serialize( $meta_value );
-               $meta_value = $wpdb->escape( $meta_value );
                if ( !empty( $insert ) )
                        $insert .= ', ';
-               $insert .= "( $network_id, '$meta_key', '$meta_value')";
+               $insert .= $wpdb->prepare( "( %d, %s, %s)", $network_id, $meta_key, $meta_value );
        }
        $wpdb->query( "INSERT INTO $wpdb->sitemeta ( site_id, meta_key, meta_value ) VALUES " . $insert );